Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds prescription values to eyewear that did not have them previously #5364

Closed
wants to merge 11 commits into from
Closed

Adds prescription values to eyewear that did not have them previously #5364

wants to merge 11 commits into from

Conversation

Staykeu
Copy link
Contributor

@Staykeu Staykeu commented Jan 1, 2024 •
edited by github-actions bot
Loading

About the pull request

Adds prescription lens effects to items such as the SG/Scout/Sniper sights, also removes old unused prescription variants of the med, sec, sci and sensor HUDs and replaces them with the default version supporting prescription effects.

Explain why it's good for the game

QoL change that makes life easier for those that have characters with impaired vision, allows the use of these eyepieces without obscuring the mask slot, be it reserved for smokes, scarfs, coifs, etc.

Testing Photographs and Procedure

Screenshots & Videos

N/A

Changelog

🆑 Stakeyng
qol: combines prescription glasses and eyewear for varying roles
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Jan 1, 2024
@567Turtle
Copy link
Contributor

Correct me if I'm wrong but you don't need to have prescription = TRUE in
/obj/item/clothing/glasses/night/m42_night_goggles/spotter,
/obj/item/clothing/glasses/night/m42_night_goggles/upp
and /obj/item/clothing/glasses/night/m42_night_goggles/m42c
because you already gave prescription = TRUE to /obj/item/clothing/glasses/night/m42_night_goggles

Additionally, I would just add prescription = TRUE to /obj/item/clothing/glasses/hud and then add prescription = FALSE to the huds that you DONT want to have a prescription (which is only one as of writing this comment, the jensen shades). This would remove the need to restate prescription = TRUE 15 different times for each and every branch off of hud.

@567Turtle
Copy link
Contributor

/obj/item/clothing/glasses/night/m42_night_goggles/upp and /obj/item/clothing/glasses/night/m42_night_goggles/m42c still have an unnecessary prescription = TRUE

@567Turtle
Copy link
Contributor

The security jensen glasses have prescription with the current code. If you don't want them to (you didn't previously) add prescription = FALSE to them.

@Staykeu
Copy link
Contributor Author

Staykeu commented Jan 2, 2024 •
edited
Loading

The security jensen glasses have prescription with the current code. If you don't want them to (you didn't previously) add prescription = FALSE to them.

i didn't add the variable to the jensens because it was an unnecessary addition to an item that gets rarely used, same goes for the second update, it simply doesnt matter

@Staykeu Staykeu marked this pull request as draft January 2, 2024 10:03
@Staykeu Staykeu closed this Jan 2, 2024
@Staykeu Staykeu deleted the spec-sight branch January 29, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Quality of Life Make the game harder to play
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Staykeu @567Turtle